Repository navigation
Conversation
jaavid134
changed the title
|
The failed jobs timed out after 5 minutes at setup steps (apt downloads for "Install libvips" / "Install ebook converters"), before any tests ran. Looks like a CI infrastructure issue, not this change. Could someone please re-run the failed jobs? Thank you! |
|
Hi, jaavid134! Thank you so much for this pull request. I've restarted the tests for you and someone will be along to review your changes soon. In the meantime, I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)." Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you. Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above. |
|
Hi @sarken, Thank you for restarting the tests and updating the Jira issue! I've just created my Jira account. My username is jaavid134, and I'll send my email address to otw-coders@transformativeworks.org so it isn't posted publicly here. I'm really happy to be contributing to one of my favourite websites. Thanks again for the warm welcome! |
sarken
left a comment
sarken
left a comment
There was a problem hiding this comment.
Thanks for working on this!
| def index | ||
| @counts = tag_counts_per_category | ||
| authorize :wrangling, :read_access? if logged_in_as_admin? | ||
| @page_subtitle = t(".wrangling_tools_page_subtitle") |
There was a problem hiding this comment.
To follow our normal i18n naming patterns, could you change this to .page_title.wrangling_tools and update the other instance of @page_subtitle to use .page_title.fandoms? (We'd appreciate it if you could also capitalize "fandoms" in the yml file when updating the key. The lowercase is no longer our house style.)
| Given I am logged in as a tag wrangler | ||
| When I go to the wrangling tools page | ||
| Then I should see "Wrangling Tools" within "h2.heading" | ||
| And I should not see "Tag Wrangling" within "h2.heading" |
There was a problem hiding this comment.
I think it would be okay to remove the two not checks in this scenario.
| Then I should see "Wrangling Tools" within "h2.heading" | ||
| And I should not see "Tag Wrangling" within "h2.heading" | ||
| And I should see the page title "Wrangling Tools" | ||
| And the page title should not include "Tag Wranglings" No newline at end of file |
There was a problem hiding this comment.
Could you add the missing newline here?
github-actions
Bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Updated page subtitles to use structured titles for fandoms and wrangling tools.
Removed assertions about 'Tag Wrangling' from the scenario.
This branch has not been deployed
2 participants
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7611
Purpose
This PR fixes the Wrangling Tools page's browser title and page heading from "Tag Wranglings"/"Tag Wrangling" to "Wrangling Tools" so they match the sidebar title, and adds a Cucumber test covering both.
Testing Instructions
Additional checks:
Go to /tag_wranglings?show=fandoms and confirm the browser title still reads "fandoms | Archive of Our Own" (unchanged).
Credit
jaavid134 (he/him)