Skip to content

ref(aci): Remove Incident lifecycle and backup handling - #128396

Open
shashjar wants to merge 1 commit into
shashjar/iswf-3254-retire-incident-modelfrom
shashjar/iswf-3254-remove-incident-lifecycle
Open

shashjar wants to merge 1 commit into
shashjar/iswf-3254-retire-incident-modelfrom
shashjar/iswf-3254-remove-incident-lifecycle

Conversation

@shashjar

@shashjar shashjar commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Refs https://linear.app/getsentry/issue/ISWF-3254/remove-incident-model.

Remove Incident-specific deletion handlers, parent-deletion relations, subscription synchronization, factories, and obsolete tests. Convert surviving tests to historical scalar mapping IDs. Exclude native Incident rows from backup/relocation handling and remove their backup fixture/comparator and unused model behavior.

The model remains registered with its schema fields until the next PR retires it.

@linear-code

linear-code Bot commented Oct 21, 2026

Copy link
Copy Markdown

ISWF-3254

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 21, 2026
@shashjar
shashjar added this pull request to stack #128402 October 21, 2026 18:30
@shashjar shashjar changed the title ref(aci): Remove Incident lifecycle and backup handling ref(aci): Remove Incident lifecycle and backup handling Oct 21, 2026
@shashjar

Copy link
Copy Markdown
Member Author

bugbot review

@shashjar
shashjar requested review from a team October 21, 2026 18:39
@shashjar
shashjar marked this pull request as ready for review October 21, 2026 18:39
@shashjar
shashjar requested review from a team as code owners October 21, 2026 18:39
@shashjar
shashjar removed request for a team October 21, 2026 18:39

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 3a3808d. Configure here.

@shashjar
shashjar force-pushed the shashjar/iswf-3254-remove-incident-lifecycle branch from 3a3808d to 72b93dd Compare October 23, 2026 20:04
@sentry

sentry Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
- - - - - - ✅ 760 uploaded

Base commit ad593d439e485a2f0acb78f04e105bfcd03a0646 did not produce snapshots to compare against. Did its snapshot job fail? Try rebasing this branch on a commit with a successful snapshot job.

⚙️ sentry-frontend Snapshot Settings

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants