Repository navigation
Conversation
|
Closing this PR and pulling in the contributor's change through #506 since maintainers weren't able to resolve the conflict directly in this PR. |
fulghum
reviewed
Nov 6, 2026
fulghum
left a comment
There was a problem hiding this comment.
These changes look good, but there's a conflict that I'm unable to resolve in this PR. I've created #506 with this same commit, from the latest main and I'll get that merged in.
In the future, if you can enable the Allow edits from maintainers settings, it makes it a little bit easier for us to resolve conflicts or make small changes and get the original PR merged in.
Author
|
Thanks @fulghum, I've enabled maintainer edits for the other PRs I have open and will make sure to do so going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated columns such as
small BOOL GENERATED ALWAYS AS (value < 8) VIRTUALcurrently fail to parse unless the comparison has an extra pair of parentheses. Accept the fullexpressionproduction in both generated-column syntaxes while preserving their outerParenExpr, so existing DDL formatting and doubly parenthesized expressions keep working.Fixes dolthub/dolt#12343.
Regression coverage exercises comparisons,
IS NULL,BETWEEN, combinedAND/OR/NOT, and arithmetic across abbreviated/full syntax, omitted/VIRTUAL/STORED persistence, single/double parentheses, and CREATE/ALTER ADD/ALTER MODIFY. It checks the generated-expression AST and column-definition format/reparse stability. The new test has 72 failing boolean cases against the original parser and passes with this change.Validation:
GOWORK=off go test ./go/vt/sqlparserpasses with Vitess's own declared dependencies.sql.gousing the repository Makefile commands; a second generation is byte-identical. Both original and changed grammars report zero shift/reduce and zero reduce/reduce conflicts.go test ./enginetest -run '^TestGeneratedColumns$' -count=1passes.GOWORK=off go test ./...did not pass: MySQL server tests require an unavailablemysqld/VT_MYSQL_ROOT; the MySQL package was interrupted while stalled inTestTLSServer. All other test packages passed.This is a standalone parser change with no module version changes or local overrides. Downstream dependency adoption is separate.