Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SELECT 1 < 2 = 1andSELECT (1,2) < (1,3) = 1currently fail to parse, although grouping the first comparison works. Introduce a left-recursive comparison tier so each scalar comparison can consume the preceding comparison's result. The right operand remains a value expression, preserving left associativity and keeping logical operators outside the comparison operands. Regeneratesql.goand add 22 AST and parse-format-parse cases covering scalar/row chains, mixed comparison operators, explicit grouping, arithmetic, logical operators, NULL, predicates and subqueries.Fixes dolthub/dolt#12345.
Validation:
GOWORK=off go test ./go/vt/sqlparser -count=1passes with the fix.TestQueriesSimple, an external 34-case execution regression, and DoltTestQueriespass with this checkout selected through an external Go workspace.No dependency version bumps or local module overrides are included. Downstream execution checks remain external until consumers adopt the parser. Validation does not include the full Vitess/MySQL-server suite or a fresh live MySQL comparison.