Repository navigation
Conversation
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
TMT tests failed. @containers/packit-build please check. |
Collaborator
Author
|
Tested (with criu patched with checkpoint-restore/criu#3146 and crun patched with #2238) in kolyshkin#2: |
kolyshkin
force-pushed
the
cr-lazy-pages
branch
from
October 12, 2026 00:38
e75bf8a to
e56dcc8
Compare
kolyshkin
force-pushed
the
cr-lazy-pages
branch
5 times, most recently
from
October 22, 2026 22:08
1013d25 to
80f051f
Compare
kolyshkin
force-pushed
the
cr-lazy-pages
branch
2 times, most recently
from
October 26, 2026 20:26
bc7ba78 to
7344d77
Compare
kolyshkin
marked this pull request as ready for review
October 26, 2026 21:33
Add the following options, compatible with runc: - checkpoint --lazy-pages, to serve the memory pages from the page server instead of saving them to the image; - checkpoint --page-server ADDRESS:PORT, to set the page server address and port; - checkpoint --status-fd FD, to get notified (by a zero byte written to FD) once the page server is ready; - restore --lazy-pages, to restore the memory pages lazily from the criu lazy-pages daemon. The public struct libcrun_checkpoint_restore_options_s is extended with the corresponding lazy_pages, page_server_address, page_server_port and status_fd fields. To keep a zero-initialized struct meaning "use the defaults", a status_fd of 0 means it is not set (and so --status-fd 0 is rejected). This requires criu_set_lazy_pages() from libcriu, which is available since CRIU 4.3. It is loaded optionally, and a clear error is returned if it is not available. Assisted-by: Claude Code (claude-opus-5-5) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
It mimics the runc "checkpoint --lazy-pages and restore" integration test, and is skipped if either CRIU or libcriu lacks lazy pages support. Assisted-by: Claude Code (claude-opus-5-5) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Now that crun supports checkpoint/restore with lazy pages, and the CRIU PPA used in CI provides CRIU 4.3 (with criu_set_lazy_pages in libcriu), remove the runc "checkpoint --lazy-pages and restore" test from the skip list. Assisted-by: Claude Code (claude-opus-5-5) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
cr-lazy-pages
branch
from
October 26, 2026 22:54
7344d77 to
bc7fab3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add lazy migration support, compatible with runc:
checkpoint --lazy-pages, to serve memory pages from the page server instead of saving them to the image;checkpoint --page-server ADDRESS:PORT, to set the page server address and port;checkpoint --status-fd FD, to get notified (by a zero byte written to FD) once the page server is ready;restore --lazy-pages, to restore memory pages lazily from thecriu lazy-pagesdaemon.The public
struct libcrun_checkpoint_restore_options_sis extended with the correspondinglazy_pages,page_server_address,page_server_portandstatus_fdfields. To keep a zero-initialized struct meaning "use the defaults", astatus_fdof 0 means it is not set (same as e.g.btf_fdorattach_prog_fdin the kernel'sbpf_attr); consequently,--status-fd 0is rejected.This requires checkpoint-restore/criu#3146, included in CRIU v4.3. For older criu versions, a clear error message is produced.