Repository navigation
ci: install libcriu-dev, require CRIU support - #2407
Merged
Merged
Conversation
The criu package in the criu PPA is now split into multiple packages (criu, libcriu2, libcriu-dev, python3-pycriu, libcompel1, libcompel-dev), following the Debian and Ubuntu packaging, so the libcriu headers and library are no longer shipped in the criu package. Install libcriu-dev (which also pulls in libcriu2), so that crun is built with CRIU support, and the checkpoint/restore tests are not silently skipped. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> Assisted-by: Claude Code (claude-opus-5-5)
Collaborator
Author
|
The irony is, w/o runc integration tests we'd never knew our CI is broken. I was thinking about adding a check for that but we don't need it. Will merge this asap to unblock CI |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Currently, CRIU support is autodetected, and if libcriu is not found, crun is silently built without checkpoint/restore support, even if --enable-criu is given explicitly. Make an explicit --enable-criu mean CRIU support is required, failing configure if libcriu is not found. Without the option, CRIU support is still autodetected, as before. Assisted-by: Claude Code (claude-opus-5-5) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Collaborator
Author
actually the check is quite simple; added as a second commit |
All the CI jobs which build crun using tests/ci.sh's build() install libcriu-dev, and some of them (checkpoint-restore, runc-integration) are pointless without CRIU support. Pass --enable-criu to configure, so that if libcriu is missing (as it happened after the criu package split in the criu PPA), the build fails rather than the checkpoint/restore tests being silently skipped or failing in a less obvious way. Assisted-by: Claude Code (claude-opus-5-5) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
ci-libcriu-dev
branch
from
October 23, 2026 08:15
a07451f to
427efe3
Compare
kolyshkin
changed the title
Collaborator
Author
|
merging w/o lgtms to unblock ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new criu 4.3 package in the criu PPA is now split into multiple packages
(criu, libcriu2, libcriu-dev, python3-pycriu, libcompel1, libcompel-dev),
following the Debian and Ubuntu packaging, so the libcriu headers and
library are no longer shipped in the criu package.
As a result, crun is built without CRIU support in CI:
and the checkpoint/restore tests are either silently skipped or, in
the runc integration tests job, fail with
unknown command checkpoint(see e.g. #2404).
Install libcriu-dev (which also pulls in libcriu2) to fix this
(the first commit is also a part of #2259).
To not let this happen again:
configure --enable-criufail if libcriu is notfound (without the option, CRIU support is still autodetected, and
--disable-criuworks as before);--enable-criuin CI builds.