Skip to content

mod: one PowerShell test per value, so three pwsh cold starts stop sharing one 5 s budget #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
backnotprop wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

mod: one PowerShell test per value, so three pwsh cold starts stop sharing one 5 s budget #2838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apps/hook/hooks/mod/inbox-reminder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,14 @@ describe("hooks.json's SessionStart compact hook", () => {
// Claude Code runs a Windows hook in Git Bash, else PowerShell (-NoProfile);
// there `$PLANNOTATOR_INBOX_REMINDER` is a PowerShell variable, always empty
// (the mod never runs on Windows anyway). The line must parse and exit 0.
// One test per value: each cold-starts pwsh once, so three starts no longer share one 5 s budget.
const pwsh = spawnSync('pwsh', ['-NoProfile', '-Command', 'exit 0'], { encoding: 'utf8' })
test.skipIf(pwsh.status !== 0)('PowerShell: prints only whitespace and exits 0, set or not', () => {
for (const value of [undefined, text, HOSTILE]) {
for (const [label, value] of [['unset', undefined], ['set to the text', text], ['set to the hostile text', HOSTILE]] as const) {
test.skipIf(pwsh.status !== 0)(`PowerShell: prints only whitespace and exits 0, ${label}`, () => {
const result = run('pwsh', ['-NoProfile', '-NonInteractive', '-Command'], value)
expect(result.status).toBe(0)
expect(result.stdout.trim()).toBe('')
expect(result.stderr).toBe('')
}
})
})
}
})