Repository navigation
mod: one PowerShell test per value, so three pwsh cold starts stop sharing one 5 s budget - #2838
Open
backnotprop wants to merge 1 commit into
Open
backnotprop wants to merge 1 commit into
backnotprop wants to merge 1 commit into
Conversation
…aring one 5 s budget The SessionStart compact hook's PowerShell test ran pwsh three times in one test. On main's unit-2 it took 2.7 to 3.5 s and on PR 2776 it hit 5008 ms and timed out. Each value is now its own test with the same three assertions; the probe for pwsh stays a shared skip condition.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
The test
hooks.json's SessionStart compact hook > PowerShell: prints only whitespace and exits 0, set or notinapps/hook/hooks/mod/inbox-reminder.test.tsstartedpwshfrom cold three times in one test (unset, the reminder text, the hostile text). Bun's default budget for the test is 5 s. On main's unit-2 shard it already uses most of that:On PR 2776 (run 42340487682, unit-2) it hit 5008 ms and timed out. Bun then killed the leftover pwsh, so the failure reads as
Expected: 0, Received: null. PR 2776 changes onlypackages/system/.Change
unset,set to the text,set to the hostile text. Each starts pwsh once and keeps the same three assertions: exit 0, stdout is only whitespace, stderr is empty.Timing
bun test apps/hook/hooks/mod/inbox-reminder.test.ts, as the unit lane runs it, without--isolate).tscforapps/hook/hooks/mod/tsconfig.jsonandapps/hook/tsconfig.server.jsonis clean. The mod tsconfig excludes*.test.ts. Gitleaks over the range found no leaks.