Skip to content

fix: apply initial page-load timeout before backend startup - #3112

Merged
KazuCocoa merged 1 commit into
masterfrom
fix/initial-page-load-timeout
Nov 1, 2026
Merged

KazuCocoa merged 1 commit into
masterfrom
fix/initial-page-load-timeout

Conversation

@KazuCocoa

Copy link
Copy Markdown
Member

Appium 4 initializes timeout capabilities by assigning BaseDriver properties directly, bypassing the XCUITest timeout setters. A session created with timeouts: {pageLoad: 45000} therefore reports 45 seconds while the remote debugger still uses the default 6 seconds.

Synchronize the initial page-load timeout through the existing setter before backend startup. This preserves the reported capability value while applying the existing internal timeout limit. Regression tests exercise the real session capability handling and remote debugger construction for explicit, zero, null, oversized, and omitted page-load timeouts.

Addresses finding 1 from the review of #3111. Targets beta, where the Appium 4 migration lives.

Validation:

  • The four explicit-value regression cases failed before the fix; the omitted-value case passed.
  • Build passed.
  • Timeout, automation-session, and context unit tests: 53 passed.
  • Lint and formatting checks passed.

@greptile-apps

greptile-apps Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Applies the initial page-load timeout before backend startup.

  • Initial page-load timeouts reach the remote debugger before backend startup.

Reviews (2) · Last reviewed commit: "fix: apply initial page-load timeout bef..." · Reviewed by Greptile

@mykola-mokhnach
mykola-mokhnach changed the base branch from beta to master November 1, 2026 07:16
@mykola-mokhnach

Copy link
Copy Markdown
Contributor

beta was promoted to master (released as 13.0.0) and the beta branch is being removed, so this PR was retargeted to master. beta was rebased onto master with new commit SHAs, so please rebase this branch onto master (e.g. git rebase --onto origin/master <old-beta-base> <branch>); until then the commit list/diff will include the old beta commits.

@KazuCocoa
KazuCocoa force-pushed the fix/initial-page-load-timeout branch from 29e97be to b6869d8 Compare November 1, 2026 15:05
@KazuCocoa

KazuCocoa commented Nov 1, 2026 •

Copy link
Copy Markdown
Member Author

Looks like this CI failure is the webdriverio's version update reason from v9 to v10 - /property/value by #3114. I'll create a followup

@KazuCocoa
KazuCocoa merged commit aca9b95 into master Nov 1, 2026
35 of 43 checks passed
@KazuCocoa
KazuCocoa deleted the fix/initial-page-load-timeout branch November 1, 2026 19:28
github-actions Bot pushed a commit that referenced this pull request Nov 1, 2026
## [13.0.2](v13.0.1...v13.0.2) (2026-11-01)

### Bug Fixes

* apply initial page-load timeout before backend startup ([#3112](#3112)) ([aca9b95](aca9b95))
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 13.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants