Skip to content

fix: route native element property requests through driver - #3116

Merged
KazuCocoa merged 1 commit into
masterfrom
fix/native-element-property-routing
Nov 1, 2026
Merged

KazuCocoa merged 1 commit into
masterfrom
fix/native-element-property-routing

Conversation

@KazuCocoa

Copy link
Copy Markdown
Member

WebdriverIO 10's getValue() requests the element's value property, exposing a missing native proxy exclusion: GET /session/:sessionId/element/:elementId/property/value is forwarded to WebDriverAgent and fails with Unhandled endpoint. This caused all 100 typing stress tests to fail in PR #3112's long-test job.

Add property GET requests to the native proxy avoidance list so the existing getProperty() handler translates them to native attribute requests. Add a regression test covering both the routing decision and the /attribute/value fallback. Follow-up to #3112; targets master.

Validation:

  • The new regression test failed before the routing fix and passes afterward.
  • Build, lint, and formatting checks passed.
  • Element command tests: 32 passed.
  • Full unit suite: 812 passed, 1 failed because local port 9100 was already occupied (EADDRINUSE in the existing mjpegServerPort test).
  • Simulator end-to-end tests were not run locally.

@greptile-apps

greptile-apps Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Routes native element property GET requests through the existing getProperty handler instead of forwarding them directly to WebDriverAgent.

  • Native element property requests use the attribute fallback.

Reviews (1) · Last reviewed commit: "fix: route native element property reque..." · Reviewed by Greptile

@KazuCocoa

Copy link
Copy Markdown
Member Author

lets see how the e2e will be here

@KazuCocoa
KazuCocoa merged commit 2235a99 into master Nov 1, 2026
39 of 43 checks passed
@KazuCocoa
KazuCocoa deleted the fix/native-element-property-routing branch November 1, 2026 22:13
github-actions Bot pushed a commit that referenced this pull request Nov 1, 2026
## [13.0.3](v13.0.2...v13.0.3) (2026-11-01)

### Bug Fixes

* route native element property requests through driver ([#3116](#3116)) ([2235a99](2235a99))
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 13.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants