Skip to content

Align float4 operators with array ordering #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dajiaohuang wants to merge 2 commits into from
Closed

Align float4 operators with array ordering #3251

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0bfb6a
Use PostgreSQL array ordering for float4 operators
dajiaohuang Oct 2, 2026
337474b
fix: preserve PostgreSQL array comparison call context
dajiaohuang Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 25 additions & 42 deletions cpp/deeplake_pg/index_search.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,72 +755,55 @@ PGDLLEXPORT Datum deeplake_cosine_similarity(PG_FUNCTION_ARGS)

PGDLLEXPORT Datum deeplake_vector_lt(PG_FUNCTION_ARGS)
{
return pg::utils::pg_try([&] {
auto v1 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(0), false);
auto v2 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(1), false);
bool result = pg::pg_index::instance().vector_lt(v1, v2);
PG_RETURN_BOOL(result);
});
ArrayType* left = PG_GETARG_ARRAYTYPE_P(0);
ArrayType* right = PG_GETARG_ARRAYTYPE_P(1);
PG_RETURN_BOOL(DatumGetBool(DirectFunctionCall2(array_lt, PointerGetDatum(left), PointerGetDatum(right))));
}

PGDLLEXPORT Datum deeplake_vector_le(PG_FUNCTION_ARGS)
{
return pg::utils::pg_try([&] {
auto v1 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(0), false);
auto v2 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(1), false);
bool result = pg::pg_index::instance().vector_le(v1, v2);
PG_RETURN_BOOL(result);
});
ArrayType* left = PG_GETARG_ARRAYTYPE_P(0);
ArrayType* right = PG_GETARG_ARRAYTYPE_P(1);
PG_RETURN_BOOL(DatumGetBool(DirectFunctionCall2(array_le, PointerGetDatum(left), PointerGetDatum(right))));
}

PGDLLEXPORT Datum deeplake_vector_eq(PG_FUNCTION_ARGS)
{
return pg::utils::pg_try([&] {
auto v1 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(0), false);
auto v2 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(1), false);
const bool result = pg::pg_index::instance().vector_eq(v1, v2);
PG_RETURN_BOOL(result);
});
ArrayType* left = PG_GETARG_ARRAYTYPE_P(0);
ArrayType* right = PG_GETARG_ARRAYTYPE_P(1);
PG_RETURN_BOOL(DatumGetBool(DirectFunctionCall2(array_eq, PointerGetDatum(left), PointerGetDatum(right))));
}

PGDLLEXPORT Datum deeplake_vector_ne(PG_FUNCTION_ARGS)
{
return pg::utils::pg_try([&] {
auto v1 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(0), false);
auto v2 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(1), false);
bool result = pg::pg_index::instance().vector_ne(v1, v2);
PG_RETURN_BOOL(result);
});
ArrayType* left = PG_GETARG_ARRAYTYPE_P(0);
ArrayType* right = PG_GETARG_ARRAYTYPE_P(1);
PG_RETURN_BOOL(DatumGetBool(DirectFunctionCall2(array_ne, PointerGetDatum(left), PointerGetDatum(right))));
}

PGDLLEXPORT Datum deeplake_vector_ge(PG_FUNCTION_ARGS)
{
return pg::utils::pg_try([&] {
auto v1 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(0), false);
auto v2 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(1), false);
bool result = pg::pg_index::instance().vector_ge(v1, v2);
PG_RETURN_BOOL(result);
});
ArrayType* left = PG_GETARG_ARRAYTYPE_P(0);
ArrayType* right = PG_GETARG_ARRAYTYPE_P(1);
PG_RETURN_BOOL(DatumGetBool(DirectFunctionCall2(array_ge, PointerGetDatum(left), PointerGetDatum(right))));
}

PGDLLEXPORT Datum deeplake_vector_gt(PG_FUNCTION_ARGS)
{
return pg::utils::pg_try([&] {
auto v1 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(0), false);
auto v2 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(1), false);
bool result = pg::pg_index::instance().vector_gt(v1, v2);
PG_RETURN_BOOL(result);
});
ArrayType* left = PG_GETARG_ARRAYTYPE_P(0);
ArrayType* right = PG_GETARG_ARRAYTYPE_P(1);
PG_RETURN_BOOL(DatumGetBool(DirectFunctionCall2(array_gt, PointerGetDatum(left), PointerGetDatum(right))));
}

PGDLLEXPORT Datum deeplake_vector_compare(PG_FUNCTION_ARGS)
{
return pg::utils::pg_try([&] {
auto v1 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(0), false);
auto v2 = pg::utils::pg_to_nd(PG_GETARG_ARRAYTYPE_P(1), false);
int64_t result = pg::pg_index::instance().vector_compare(v1, v2);
PG_RETURN_INT32(result);
});
ArrayType* left = PG_GETARG_ARRAYTYPE_P(0);
ArrayType* right = PG_GETARG_ARRAYTYPE_P(1);
if (DatumGetBool(DirectFunctionCall2(array_eq, PointerGetDatum(left), PointerGetDatum(right)))) {
PG_RETURN_INT32(0);
}
PG_RETURN_INT32(
DatumGetBool(DirectFunctionCall2(array_lt, PointerGetDatum(left), PointerGetDatum(right))) ? -1 : 1);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
}

PGDLLEXPORT Datum deeplake_maxsim(PG_FUNCTION_ARGS)
Expand Down