Repository navigation
Ship a usable third public room - #114
Conversation
Replace the unavailable Cg Arch gallery card with the CC BY Haussmann apartment, while retaining the separately licensed Cg Arch metadata for local use. Track the reviewed SOG, collision GLB, and creator preview so a clean Vercel build contains the actual room instead of showing a disabled card. Fail the frontend build if this public room's required assets are absent. Update the room guide and William's Kanban/TODO record with asset checksums and local acceptance. Verified Vercel-mode output includes the room files; local gallery opened the textured apartment with author credit and a HERRÅKRA armchair was saved and shown in the floor plan/cart. Full backend suite: 393 tests, 5 skipped; frontend: 209 scene plus 25 packaging/auth tests; board: 6 tests. The approximate 48 MB of binary assets increases repository and deployment size, and scene scale remains synthetic.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: baa3d37a5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "id": "haussmann-apartment", | ||
| "title": "The Haussmann apartment", | ||
| "description": "An unfurnished Paris apartment with tall windows and parquet floors.", | ||
| "thumbnail": "/room-previews/haussmann-apartment.webp" |
There was a problem hiding this comment.
On /rooms, this creator-owned thumbnail is displayed before a visitor enters the room, but RoomSelection renders only the image, title, and description and never loads the manifest attribution. The repository identifies the preview as Stéphane Agullo’s CC BY asset, and shared/rooms/haussmann-apartment/license.txt explicitly requires author credit, so the public gallery currently uses it without the required author/source/license notice. Add attribution metadata to the gallery entry and render it beside the preview, or replace the preview with an owned asset.
Useful? React with 👍 / 👎.
Summary
Replace the disabled public Cg Arch card with the already prepared, redistributable CC BY Haussmann apartment. Include the 43.1 MB SOG, 4.9 MB collision GLB and creator preview in a clean frontend build. Keep Cg Arch available only to locally provisioned machines under its separate Blendkit terms.
The Vite room plugin now fails the build if the public Haussmann visual or collision asset is absent. The existing manifest provides Stéphane Agullo attribution in the room.
Closes #113.
Verification
OPENAI_API_KEY= COMPILE_LIVE_TEST=0 uv run python manage.py test→ Ran 393 tests in 13.906s; OK (skipped=5).npm test→ 209 scene tests and 25 packaging/auth tests passed.VERCEL=1 npm run build→ emitted the SOG (43,111,562 bytes), collision GLB (4,867,408 bytes) and preview (71,628 bytes).node --test .github/extensions/project-manager/tests/board.test.mjs→ 6 passed./rooms→/room/haussmann-apartmentrendered the unfurnished interior and CC BY author link; a HERRÅKRA chair saved at X75/Z100, appeared on the floor plan, and changed Cart (0) to Cart (1).The reviewed room scale remains assumed and is labeled
synthetic_demoin its manifest. The new tracked room files increase repo and deployment size by about 48 MB. Production deployment and exact public browser verification follow the merge.