Repository navigation
Build against the current libbdsg: C++20, and link jansson - #82
Merged
Merged
Conversation
The libbdsg-easy update for faster PackedGraph construction (#81) brought headers that use std::as_const and operator<=>, and a libbdsg.a that calls jansson. Every tool here includes those headers at -std=c++14, so a fresh clone of master stops in the first compile with "'as_const' is not a member of 'std'", and after that halRemoveDupes fails to link with undefined json_* references. Working copies that had installed the previous headers under deps/libbdsg-easy/include kept building, which is how it got merged. -std=c++20 (gcc 10+; the release containers are on 11 and 13), and -ljansson next to the other system libraries. The static release needs libjansson.a, which the -dev package carries. Verified from a fresh recursive clone: all seven tools build and the suite passes with them on PATH. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013YWGkqE3ND862JF8QRZERV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libbdsg-easy update for faster PackedGraph construction (#81) brought headers that
use std::as_const and operator<=>, and a libbdsg.a that calls jansson. Every tool here
includes those headers at -std=c++14, so a fresh clone of master stops in the first
compile with "'as_const' is not a member of 'std'", and after that halRemoveDupes fails
to link with undefined json_* references. Working copies that had installed the
previous headers under deps/libbdsg-easy/include kept building, which is how it got
merged.
-std=c++20 (gcc 10+; the release containers are on 11 and 13), and -ljansson next to the
other system libraries. The static release needs libjansson.a, which the -dev package
carries. Verified from a fresh recursive clone: all seven tools build and the suite
passes with them on PATH.
Found while switching cactus from hal2vg release binaries to a pinned source build (
downloadPangenomeTools): a fresh recursive clone of master does not build. With this, all seven tools build from a fresh clone and the suite passes (111 tests).🤖 Generated with Claude Code
https://claude.ai/code/session_013YWGkqE3ND862JF8QRZERV