Repository navigation
Conversation
A command can spend longer than AUTH_RESPONSE_TIMEOUT behind another command. Start its first step when it reaches the front and is ready to run, so queue time cannot cause a step timeout before execution. When a VCSEC or infotainment authentication attempt times out, refresh the step timer for the retry. Keep the overall elapsed time so the existing stale-session recovery can still disconnect a stuck session. Regression tests exercise queue wait, both authentication domains, and the stale-session limit. All 330 native CTest cases pass.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands can hit the step timeout before they reach the front of the queue. The same timeout can also abort a VCSEC or Infotainment authentication retry on the next loop iteration, before a new request is sent.
Start the first step timer when the queued command is ready to run. Refresh the step timer when an authentication retry begins. Keep the original command start time for the existing stale-session limit, so a persistently stuck session still disconnects.
Three new regression cases fail on the current base and pass with this change. They cover a command waiting past the step timeout and an authentication retry in each domain. Both authentication cases also verify that an exhausted session reports failure once and disconnects. All 330 native CTest cases passed.