Skip to content

fix(vehicle): start step timers when commands become runnable - #127

Open
vwidor wants to merge 1 commit into
yoziru:mainfrom
vwidor:fix/queue-auth-timeouts
Open

vwidor wants to merge 1 commit into
yoziru:mainfrom
vwidor:fix/queue-auth-timeouts

Conversation

@vwidor

@vwidor vwidor commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Commands can hit the step timeout before they reach the front of the queue. The same timeout can also abort a VCSEC or Infotainment authentication retry on the next loop iteration, before a new request is sent.

Start the first step timer when the queued command is ready to run. Refresh the step timer when an authentication retry begins. Keep the original command start time for the existing stale-session limit, so a persistently stuck session still disconnects.

Three new regression cases fail on the current base and pass with this change. They cover a command waiting past the step timeout and an authentication retry in each domain. Both authentication cases also verify that an exhausted session reports failure once and disconnects. All 330 native CTest cases passed.

A command can spend longer than AUTH_RESPONSE_TIMEOUT behind another
command. Start its first step when it reaches the front and is ready
to run, so queue time cannot cause a step timeout before execution.

When a VCSEC or infotainment authentication attempt times out, refresh
the step timer for the retry. Keep the overall elapsed time so the
existing stale-session recovery can still disconnect a stuck session.

Regression tests exercise queue wait, both authentication domains,
and the stale-session limit. All 330 native CTest cases pass.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant