Repository navigation
add hebrew translation - #993
Merged
Merged
Conversation
whyboris
approved these changes
Sep 25, 2026
whyboris
left a comment
whyboris
left a comment
Owner
There was a problem hiding this comment.
Thank you for the contribution 🎉 🙇 🎉
Looks great 😁
Contributor
Author
|
Hebrew shows up in the settings dropdown now, backed by a full he.json, so thanks @whyboris for reviewing and merging #993. The i18n README made the wiring easy.
My open-source work is collected at github.com/theluckystrike. If you ever want to send a small one-time sponsorship through github.com/sponsors/theluckystrike, it'd mean the translation time felt appreciated, and I'll gladly keep sending Video Hub App fixes. Zero obligation.
Michael
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Hebrew to the app, as requested in #697.
What it changes
i18n/he.json is a new file with all 533 strings translated from en.json, following the same nested structure and key order as the other locale files. The three integration files are updated following the patterns in i18n/README.md, so 'he' appears in the SupportedLanguage type, the LanguageLookup map, and the settings dropdown.
Why
Hebrew was the requested addition and the issue has been open since 2021.
How I verified
Every key in en.json has a Hebrew value, the JSON parses cleanly, and the flattened key sets of en.json and he.json are identical. Placeholders and technical tokens like FPS are preserved.
Happy to adjust anything, and thanks for the very clear i18n/README.md that made this easy.