Repository navigation
Move <persistentwidget> tests from wpt_internal to external/wpt - #63804
Merged
Merged
Conversation
Because VirtualTestSuites configures the persistent-widgets virtual test suite with "exclusive_tests":"ALL", the base wpt_internal/ tests are skipped. However, blink_wpt_tests runs with TestLists/content_shell.filter (which only includes explicitly allowlisted virtual/.../wpt_internal/* suites), and headless_shell_wpt_tests and chrome_wpt_tests only run tests under external/wpt/. As a result, virtual/persistent-widgets was not running on CQ/CI trybots when located in wpt_internal/. Moving the tests to external/wpt ensures that virtual/persistent-widgets runs on CQ/CI trybots and allows routing the suite to chrome_wpt_tests via TestLists/chrome.filter in a follow-up patch to run the tests on chrome instead of content_shell for more test coverage. Bug: 537818859 Change-Id: Iff749149cb8f254280ee6aff144324b6bf34ae6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8465024 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1721085}
wpt-pr-bot
approved these changes
Oct 16, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because VirtualTestSuites configures the persistent-widgets virtual test
suite with "exclusive_tests":"ALL", the base wpt_internal/ tests are
skipped. However, blink_wpt_tests runs with
TestLists/content_shell.filter (which only includes explicitly
allowlisted virtual/.../wpt_internal/* suites), and
headless_shell_wpt_tests and chrome_wpt_tests only run tests under
external/wpt/. As a result, virtual/persistent-widgets was not running
on CQ/CI trybots when located in wpt_internal/.
Moving the tests to external/wpt ensures that
virtual/persistent-widgets runs on CQ/CI trybots and allows routing the
suite to chrome_wpt_tests via TestLists/chrome.filter in a follow-up
patch to run the tests on chrome instead of content_shell for more test
coverage.
Bug: 537818859
Change-Id: Iff749149cb8f254280ee6aff144324b6bf34ae6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8465024
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1721085}