Repository navigation
Support Windows and test it in CI - #12
Merged
Merged
Conversation
- doctor: check whether the app process runs with OpenProcess/GetExitCodeProcess on Windows; os.kill(pid, 0) terminates the process there. - init/uninstall write files with LF line endings on every platform. - Tests read files as UTF-8 and handle `profyle run` running the command as a child on Windows. - CI: the windows-latest job now blocks merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XW9SRqVFwcAobWhkRBmHq5
subprocess.run returns a CompletedProcess, which has no pid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XW9SRqVFwcAobWhkRBmHq5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes Profyle work on Windows and makes the
windows-latestCI job block merges (it was experimental in #9).profyle doctorkilled the app it checked on Windows: there,os.kill(pid, 0)terminates the process. On Windows it now usesOpenProcess+GetExitCodeProcessthrough ctypes, and "access denied" counts as running.profyle init/uninstallalways write LF line endings, so the files they write don't change line endings depending on who ran them.newline="\n";profyle runis tested on the Windows path, which runs the command as a child process because Windows has no exec;os.killprocess-state cases are POSIX-only, and a Windows-only test covers the new check.windows-latest(py3.12) is no longercontinue-on-error. macOS and 3.14 stay experimental.Type of change
How was it tested?
windows-latestCI job is what verifies it.Checklist
uv run pytestpassesuv run ruff check profyle testspassesREADME.md/CHANGELOG.mdupdated if users will notice the changeclaude-plugin/skills/still describes the tools correctly (n/a)🤖 Generated with Claude Code
https://claude.ai/code/session_01XW9SRqVFwcAobWhkRBmHq5
Generated by Claude Code