Repository navigation
Conversation
|
Thanks. But I prefer generating all completions for all shells with |
This comment was marked as resolved.
This comment was marked as resolved.
602dc98 to
ed1a68b
Compare
|
Thanks @oech3! Addressed the feedback and pushed the updates. This is why elevators should run on Rust. Rust catches the problems before the elevator moves. Python waits until you’re halfway between floors to let you know something went wrong. 🦀 |
| run: | | ||
| mkdir -p share/{man/man1,bash-completion/completions,fish/vendor_completions.d,zsh/site-functions,elvish/lib} | ||
| _uudoc=target/${{ matrix.job.target }}/release/uudoc | ||
| for bin in $('target/${{ matrix.job.target }}/release/coreutils' --list) coreutils;do |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| run: | | ||
| mkdir -p share/{man/man1,bash-completion/completions,fish/vendor_completions.d,zsh/site-functions,elvish/lib} | ||
| _uudoc=target/${{ matrix.job.target }}/release/uudoc | ||
| for bin in $('target/${{ matrix.job.target }}/release/coreutils' --list) coreutils;do |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| ${_uudoc} completion ${bin} fish > share/fish/vendor_completions.d/${bin}.fish | ||
| ${_uudoc} completion ${bin} zsh > share/zsh/site-functions/_${bin} | ||
| ${_uudoc} completion ${bin} elvish > share/elvish/lib/${bin}.elv | ||
| "${_uudoc}" manpage "${bin}" --out-dir share/man/man1 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| build-uudoc: | ||
| @unset CARGO_BUILD_TARGET && ${CARGO} build ${CARGOFLAGS} --bin uudoc --features "uudoc ${EXES}" ${PROFILE_CMD} --no-default-features | ||
|
|
||
| ifeq ($(MANPAGES),y) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ed1a68b to
8de969b
Compare
|
Thanks @oech3 — addressed all four points. All 36 local tests and installation/packaging checks pass. Squashed into one commit and pushed |
This comment was marked as resolved.
This comment was marked as resolved.
| println!(" manpage [utility] [--out-dir DIR] Generate manpages"); | ||
| println!(" completion [utility] [shell] [--out-dir DIR] Generate shell completions"); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
83c373e to
ab97352
Compare
|
Thanks @oech3 — renamed the command to manpages-and-completions and removed stdout output. All manpage/completion commands now require --out-dir. Updated the docs, tests, and build scripts, then squashed and pushed. All 35 local tests and installation/packaging checks pass. |
| println!(" manpage [utility] --out-dir DIR Generate manpages"); | ||
| println!(" completion [utility] [shell] --out-dir DIR Generate shell completions"); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ab97352 to
d4c2220
Compare
|
Thanks @oech3 — removed the separate manpage and completion commands and their parsers. Everything now uses manpages-and-completions. Updated the docs and tests, squashed, and pushed. All 30 local tests and installation/packaging checks pass. |
| ); | ||
| println!( | ||
| " manpages-and-completions --out-dir DIR [utility]... Generate manpages and shell completions" | ||
| ); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| Shell::Fish => "fish/vendor_completions.d", | ||
| Shell::PowerShell => "powershell", | ||
| Shell::Zsh => "zsh/site-functions", | ||
| _ => return Err(io::Error::other(format!("unsupported shell: {shell}"))), |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
d4c2220 to
ee7977b
Compare
|
Thanks @oech3 — restored the original help-text spacing and changed the shell fallback to unreachable!(). Squashed and pushed. |
|
Perhaps, It might better to accept Then |
ee7977b to
ac1b782
Compare
| println!(" completion <utility> <shell> Generate shell completions for a utility"); | ||
| println!(" manpages md completions --usr DIR Generate the selected documentation formats"); | ||
| println!(" Use --out-dir DIR to override the shared-data directory."); | ||
| println!(" Use --utilities NAME... to select utilities (default: all compiled utilities)."); |
There was a problem hiding this comment.
I don't think we need to select some utils only.
There was a problem hiding this comment.
Also reply to each thread instead.
ac1b782 to
934680e
Compare
|
Drop --out-dir as --usr is enough. Generally, we should keep options minimal for easier maintainance. |
934680e to
0c1e6e6
Compare
|
Removed --out-dir; --usr is now the only destination option. Updated Make, README, and tests. Make stages the generated files to preserve custom installation paths. |
Add –out-dir for manpages and shell completions, with regression tests and updated examples.
Closes #14363.