Skip to content

uucore: export ArgumentLocation from format - #15387

Open
limadog9 wants to merge 1 commit into
uutils:mainfrom
limadog9:fix/uucore-export-argument-location
Open

limadog9 wants to merge 1 commit into
uutils:mainfrom
limadog9:fix/uucore-export-argument-location

Conversation

@limadog9

Copy link
Copy Markdown
Contributor

Export ArgumentLocation from uucore::format and add a runnable example covering both argument-selection variants.

Closes #10089.

@codspeed

codspeed Bot commented Oct 15, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 6.81%

⚠️ 119 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

❌ 1 regressed benchmark
✅ 400 untouched benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation factor_thirteen_39_bit_primes 8.7 s 9.3 s -6.81%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing limadog9:fix/uucore-export-argument-location (5e4e5f6) with main (2fb77e8)

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uucore::format::ArgumentLocation is not publically re-exported

1 participant