Repository navigation
mv: diagnose directory overwrites of symlink destinations - #15366
Merged
RenjiSann merged 1 commit intoOct 15, 2026
Merged
Conversation
Check the destination entry without following its symlink target so missing or inaccessible referents do not fall through to a raw rename error. Extend the regression to cover existing and dangling symlinks. Closes uutils#15358
Collaborator
|
Thanks ! |
sylvestre
reviewed
Oct 15, 2026
| move_files_into_dir(&[source.to_path_buf()], target, opts) | ||
| } | ||
| } else if source_is_dir && target.exists() { | ||
| } else if source_is_dir && target.symlink_metadata().is_ok() { |
Contributor
There was a problem hiding this comment.
with a dangling symlink, is_writable follows it and returns false, so in a terminal we now prompt before failing, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the destination entry without following its symlink target so missing or inaccessible referents do not fall through to a raw rename error. Extend the regression to cover existing and dangling symlinks.
Closes #15358