Repository navigation
Conversation
Merging this PR will degrade performance by 24.56%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | factor_three_39_bit_primes |
593.6 ms | 1,494.2 ms | -60.27% |
| ❌ | Simulation | factor_thirteen_39_bit_primes |
8.8 s | 9.3 s | -4.88% |
| ⚡ | Simulation | factor_five_38_bit_primes |
1.9 s | 1.7 s | +13.62% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing oech3:stty-unsafe (7e3e80e) with main (2e28cc3)2
Footnotes
-
70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(f286c98) during the generation of this report, so 2e28cc3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
8c0b529 to
39bc936
Compare
ff11e70 to
f100d7d
Compare
|
GNU testsuite comparison: |
9be3124 to
d420658
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Would it be possible to separate the refactor replacing |
|
It is very difficult since |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
b5e10de to
a0b3f27
Compare
a820e39 to
5745437
Compare
xtqqczze
left a comment
There was a problem hiding this comment.
What happens on Linux when arbitrary baud rates are not supported (i.e. with glibc < 2.42)? Do we panic, return an error, or fall back to a different behavior?
|
This should work for all libcs since this does not use glibc's API and uses |
We have downstream consumers using |
|
No. We still don't use same C-function with GNU which cause panic at |
|
|
|
On Ubuntu 24.04 runner (legacy glibc), I got |
|
I think I understand now: in Rustix |
|
|
|
So use_libc allows us |
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
692124b to
7e3e80e
Compare
rustixmanages baud rate byu32on all platforms. But OS itself should support any baud to actually use any baud. This PR adds support for any baud on Linux kernel (since bsd was already supported atnixcrate).rustixhasu32-> enum decoder.