Repository navigation
tests: date: skip the locale %x/%X/%r test under WASI - #15236
Merged
Merged
Conversation
The test checks the host for the locale, but the WASI guest does not inherit LC_ALL and prints the C locale's format.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_date_format_locale_date_and_timefails in the wasm32-wasip1 job since #15130. The test checks that the locale exists on the host, but the WASI guest does not getLC_ALL, so it prints the C format (01/19/97). Skip it underwasi_runner, like the other tests that setLC_ALL.Closes #15229