Repository navigation
install: print the OS error, not its Debug form, when removing the destination fails - #15015
Merged
sylvestre merged 2 commits intoOct 11, 2026
Merged
Conversation
|
GNU testsuite comparison: |
Collaborator
|
please rebase for CI |
Devel08
reviewed
Oct 3, 2026
| show_error!( | ||
| "{}", | ||
| translate!("install-error-failed-to-remove", "path" => target.quote(), "error" => format!("{e:?}")) | ||
| translate!("install-error-failed-to-remove", "path" => target.quote(), "error" => strip_errno(&e)) |
Contributor
There was a problem hiding this comment.
Also, do you think that we should remove "Error: " from install-error-failed-to-remove? So that it becomes Failed to remove existing file { $path }. { $error } as the GNU error message is install: cannot create directory 'r--': Permission denied
Collaborator
|
@koopatroopa787 Please fully resolve #15003, or remove |
koopatroopa787
force-pushed
the
install-failed-remove-error-message
branch
from
October 4, 2026 12:29
648eb98 to
6df30fd
Compare
Contributor
Author
|
Rebased, dropped the test and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When install could not remove an existing destination file, the message ended with the Rust
Debugform of the error (Error: Os { code: 13, kind: PermissionDenied, ... }). Both removal sites now format it withstrip_errno, and the redundantError:prefix is dropped from the message, so it readsFailed to remove existing file 'r--/f'. Permission denied.This does not change the separate second line (
install: Permission denied) mentioned in the issue.Related to #15003