Repository navigation
docs: install @latest in the npm quickstart and read the provider config once - #198
Merged
Merged
Conversation
…fig once The npm-only quickstart pinned @udibo/oauth2@0.52.0 (0.53.0 is current) and wrote the issuer, client id, secret and redirect URI twice: in idp.json and as defaults in app.ts. The app now reads idp.json, so the pairing is one source. The install uses @latest, and the local-provider guide's pairing section says the quickstart app does this. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
=======================================
Coverage 94.07% 94.07%
=======================================
Files 148 148
Lines 11729 11729
Branches 2765 2765
=======================================
Hits 11034 11034
Misses 232 232
Partials 463 463 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 0.54.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The npm-only quickstart (#194) pinned
@udibo/oauth2@0.52.0, though 0.53.0 is current, and wrote the issuer, client id, secret and redirect URI twice: inidp.jsonand as defaults inapp.ts. Edit one and the other drifts.Outline
docs/quickstart.md: install withnpm install @udibo/oauth2@latest hono @hono/node-server(no pinned versions; points at the changelog).app.tsnow readsidp.jsonand buildsDirectClientfrom itsissuerand first client; theAUTH_*environment variables still override each value for a hosted issuer.docs/guides/run-a-local-identity-provider.md: the pairing section says the quickstart app reads the file, so each value is written once.llms-full.txtregenerated.pnpm add @udibo/oauth2@latest); I re-checked and found no remaining stale version there.Verification
npm init -y,npm pkg set type=module,npm install @udibo/oauth2@latest hono @hono/node-server(resolved 0.53.0, hono 4.13.18, @hono/node-server 2.1.7). Extractedidp.jsonandapp.tsfrom the final quickstart text, rannpx udibo-oauth2 idp dev --config idp.jsonandnode app.ts./dashboardwithout a session 302 to/auth/login; that redirects to the provider's/authorize(state, S256 PKCE,redirect_uri=http://127.0.0.1:3100/auth/callback); POST/loginas alice returned 303;/authorizeredirected to the callback withcodeandiss=http://127.0.0.1:9000;/auth/callback(code exchange on the server) returned 302 to/dashboard;/dashboardreturned 200 with "Hello, Alice Example".pnpm checkis green (build, typecheck, lint, format, doc-lint, doc-check, doc-links, llms:check). Theignoresnippet budget is unchanged.Risk
Documentation only. Unpinned
honoand@hono/node-servercan move; the quickstart was run against the versions above.🤖 Generated with Claude Code