Repository navigation
Sync output of async execution - #286
Open
KillerxDBr wants to merge 3 commits into
Open
KillerxDBr wants to merge 3 commits into
KillerxDBr wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After asynchronously compiling some of my old aoc code full of warnings, the compiler output was completelly mangled and unreadable, i had the same problem with makefiles before, but that has an option to sync output, so i implemented it in nob.
The implementation changes Nob_Proc to a struct that store 3 fds(the proc itself and its redirected outputs), use pipes to capture the non redirected output and simply dumps it to standard out/err when the subprocess end (nob_procs_flush or nob__proc_wait_async)
To enable it just set option sync_output to true in nob_cmd_run:
Enabled the good old pedantic flag to give me some warnings since i already fixed the old ones

Before:
After:
