Repository navigation
Reuse regional geometry and owned route metadata - #279
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
Adapt only route-neighbor metadata reuse from #208. Prepare metadata lazily in original scan order within the existing owned-frontier contract; preserve dynamic closure, costs, candidate ordering, search budgets, and blocker-label behavior.
imrishabh18
marked this pull request as ready for review
October 20, 2026 22:28
0hmX
approved these changes
Oct 22, 2026
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port-point routing repeated static neighbor checks throughout each owned search, and selective rerips rebuilt intersection geometry even in untouched regions. Reuse both forms of stable state while preserving the selected paths, ordering, routing work, and invariant checks.
Visual snapshots
PNG previews of the checked SVG regression snapshots, generated from the live reference and optimized test observations.
Regional metadata reuse. The port heatmap records 1,447 → 82 hop-ID evaluations over 50 paired steps with identical state and stats.
SVG snapshot · Snapshot test
Selective region rebuilding. Ripping route 0 changes only region 0: rebuild one segment instead of five while retaining the same committed copper.
SVG snapshot · Snapshot test
The SVGs are regression-tested; the PNGs above are rendered from those exact checked-in SVGs for inline display.
OWNED_REGIONAL_HOP_FRONTIERcontract. Live closure, best costs, congestion, penalties, and scoring still run for each candidate. Lazy preparation preserves early-goal and exception order.The neighbor metadata idea is adapted from #208. This patch isolates cache reuse; it excludes that PR's owner-floor, dominance-pruning, and tie-order changes.
Validation with snapshot regression coverage (production unchanged from benchmarked
bee74730028acc3fe72a1132bef3ef89df0238d7):b6d233e9f40324bacc9393ce4038ec8ec155cc91433b083d49a392546681e860, every non-timing solve-graph metric, all 2,000,000 inner iterations, and all 5,683,414 frontier expansions.SRJ18 regional port pathing takes 5.97% less time overall and 13.43% less on sample 6 in the combined consumer benchmark. The combined consumer patch is benchmarked in tscircuit-autorouter #3160: 107 scenarios on paired Blacksmith ARM runners, unchanged effort/search limits, all 106 completed route SVGs byte-identical, and no new completion or DRC failures. The five completed selected SRJ28 cases take 19.26% less total time (3.15% including the unchanged timeout); the heaviest completed case is 39.16% faster and reproduces a 37.01–44.80% speedup in a four-pass order control. Dataset01 is 2.92% faster in one paired run, while SRJ18 total time is effectively flat. These end-to-end figures measure the combined solver changes; they are not isolated attribution to this PR. Peak RSS is mixed and variable, including a 19.24% increase for sample 37 in the primary run that does not consistently reproduce in the order control. No uniform RSS reduction is claimed. Full per-case results, quality checks, memory quantiles, limitations and workflow links are in the consumer PR.
Snapshot regression coverage now records both optimizations with the original behavior as the live oracle:
These follow-up commits change only tests and checked-in deterministic snapshots. Production code and dependency pins are unchanged from the benchmarked revisions. The snapshots record operation counts rather than elapsed time. All four dependency solver suites (500 passing tests), all five repository type checks, and the autorouter goal regression pass locally.
Visual follow-up validation: all 500 dependency solver tests pass locally with four existing skips; all five repository type checks and the autorouter visual regression pass. Solver production code and runtime dependency pins are unchanged. The existing local formatter is pinned to Biome 2.5.15 for reproducible CI checks.
Formatting reproducibility: the floating Biome range began resolving 2.6.2, which introduced Markdown/YAML formatting failures in unchanged files. Pinning the locally validated 2.5.15 retains all format checks and keeps this PR focused on the solver and visual tests.