Skip to content

feat: Add ranked play hands to user response - #729

Open
Layendan wants to merge 2 commits into
tosuapp:masterfrom
Layendan:feat/ranked-play-cards
Open

Layendan wants to merge 2 commits into
tosuapp:masterfrom
Layendan:feat/ranked-play-cards

Conversation

@Layendan

@Layendan Layendan commented Oct 27, 2026 •

Copy link
Copy Markdown
  1. Problem: Mentioned when first adding ranked play
  2. Solution: Kind of complicated which is why I left comments in the code. The user only has access to card GUIDs, not the maps themselves. Those are owned by the multiplayer client in a dict. So I have to grab the multiplayer client and get the playlistitems using the GUID as a key and return those
  3. Affected Files: lazer.ts, types.ts, process.ts, offset.json (todo)
  4. Verification: I have no idea how to use dotnet-dump so I let AI generate values for tachyon (2026.1026.0) and tested myself against those. (Here are the values I used, not adding them to the pr since AI generated and not valid values for current 2026.1005.0 version) if you could please update the offset.json with correct values
  5. AI Declaration: Used Claude Opus 5.5 for helper functions in process.ts, most likely needs validation since I don't fully understand c# guid and dict pointer reader

I'd also want to add sigma and rank, but they're only present on tachyon atm so I didn't include them in this pr.

offsets.json: Ver. 2026.1005.0

Adds:

  • osu.Game.Online.Multiplayer.MultiplayerClient.cardsWithPlaylistItems (single variable, existing class)
  • osu.Game.Online.Multiplayer.MatchTypes.RankedPlay.RankedPlayCardItem (new class)
  • osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.RankedPlayCardWithPlaylistItem (new class)
  • osu.Game.Online.Rooms.MultiplayerPlaylistItem (new class)

@GabuTheDev GabuTheDev added area:memory Regarding readouts from the osu client. area:server The nodejs backend of tosu. labels Oct 27, 2026
@GabuTheDev
GabuTheDev self-requested a review October 27, 2026 14:08

@GabuTheDev GabuTheDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified offsets. Looks fine.
Haven't tested in-game though.

};
'osu.Game.Online.Multiplayer.MultiplayerClient': {
room: number;
cardsWithPlaylistItems: number;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really bad name?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from how they named it

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I know. I was just saying :)

@GabuTheDev

Copy link
Copy Markdown
Member

if you could please update the offset.json with correct values

Our generator outputs this:
offsets.json

@Layendan

Copy link
Copy Markdown
Author

if you could please update the offset.json with correct values

Our generator outputs this: offsets.json

Tested on 2026.1005.0 and works fine

GabuTheDev
GabuTheDev previously approved these changes Oct 28, 2026

@GabuTheDev GabuTheDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of these AI comments, but whatever.

@GabuTheDev
GabuTheDev requested a review from KotRikD October 28, 2026 06:27
@GabuTheDev GabuTheDev added the blocked/offsets Needs changes to the internal offsets generator to not break tosu on prod. label Oct 28, 2026
@Layendan

Copy link
Copy Markdown
Author

Not a fan of these AI comments, but whatever.

Tbh me neither, should I remove them?

@Layendan

Copy link
Copy Markdown
Author

also should I push the new offets to the branch, or is it something you need to do on the server?

@GabuTheDev

GabuTheDev commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Tbh me neither, should I remove them?

as you please.

also should I push the new offets to the branch, or is it something you need to do on the server?

Add them, yes. Add a note and game version in the PR description. They might become outdated at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:memory Regarding readouts from the osu client. area:server The nodejs backend of tosu. blocked/offsets Needs changes to the internal offsets generator to not break tosu on prod.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants