Repository navigation
Keep disabled choices out of search selections - #531
Open
HocVoNgThai wants to merge 1 commit into
Open
HocVoNgThai wants to merge 1 commit into
HocVoNgThai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR addresses?
Filtering can make disabled choices selectable in both
select()andcheckbox(). For example, searchingbetin['alpha', Choice('beta', disabled=True), 'betty']and pressing Enter returns the disabledbetarather thanbetty.How did you solve it?
Exclude disabled choices from search matches, check navigation against the displayed choices and move the cursor to a selectable item after filtering. The example now returns
betty. If no enabled choice matches, preserve the existing full-list fallback while skipping disabled entries. Adds four regression cases covering both prompts and fallback behavior.Checklist
Closes #530