Repository navigation
Respect checkbox navigation boundaries after skipping unavailable items - #529
Open
HocVoNgThai wants to merge 1 commit into
Open
HocVoNgThai wants to merge 1 commit into
HocVoNgThai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR addresses?
On
master,checkbox(cycle_list=False)still wraps past disabled choices, separators and the boundaries of filtered results. For example, with['first', 'last', Separator()], pressing Down twice, Space and Enter returns['first']instead of['last'].How did you solve it?
Check for wrapping after skipping unavailable choices, using the cursor's previous and resulting positions. The example now stays on
last; filtered results also stop at their visible boundaries. Adds four compact regression cases for both directions and unselectable edge types.Checklist
Closes #528