Repository navigation
Conversation
Add --no-interaction to the Makefile install target so CI can call make install directly instead of running poetry install itself. This way CI exercises the same install path contributors and ReadTheDocs use. Closes tmbo#292
Author
|
Hi @tmbo 👋 This is my first PR here, so the CI workflows are waiting for approval. Could you approve them when you have a moment? I've verified the change on my fork (all jobs green!) and locally (make install, make test, make types, make lint). Happy to adjust anything. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --no-interaction to the Makefile install target so CI can call make install directly instead of running poetry install itself. This way CI exercises the same install path contributors and ReadTheDocs use.
Closes #292
What is the problem that this PR addresses?
...
How did you solve it?
...
Checklist