Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR addresses?
Accepting
/in the path prompt returns an empty string. It happens both when typing the root and when accepting it as the default. The trailing-separator cleanup removes the root separator along with ordinary directory separators; on Windows the same cleanup can turn a drive root into a drive-relative path.How did you solve it?
Keep a path unchanged when it equals its native
Path.anchor. Continue removing one trailing separator from non-root paths.The input-pipe tests cover typed/default filesystem roots, separator-only roots, Windows UNC roots, and the existing non-root cleanup. Four root cases fail against the original code on macOS.
Validation on macOS arm64 / Python 3.13.15:
git diff --checkpasses.PromptSessionargument-type errors occur identically on the branch and unmodified base5a68c2d.Native Windows Server 2025 / Python 3.13 verification also passes: 175 tests, no skips, including the UNC-root test, plus Mypy on all 19 source files. Fork CI run. The verification workflow is on a separate fork-only branch based on this exact PR commit; it is not part of this PR.
Developed and tested with OpenAI Codex assistance; no human review is claimed.
Checklist