Repository navigation
Conversation
Each push now adds a `scope` extra_label for the metric set it carries, in both the single-pusher and split-pusher setups. Observability can then drop tenant metrics from the central forward without touching cluster metrics. Part of REAL-1050. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
CRAP Score Report |
Contributor
Author
|
Closing: Observability is dropping all service=realtime metrics from the central forward, and the existing tenant label covers any tenant matching. See the #team-realtime thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each push now adds a
scopeextra_label for the metric set it carries, in both the single-pusher and split-pusher setups. Observability can then drop tenant metrics from the central forward without touching cluster metrics.Part of REAL-1050.
What kind of change does this PR introduce?
Feature.
What is the current behavior?
The pusher sends global and tenant metrics as separate requests, but both carry the same labels (
service=realtime,cluster=<name>). VictoriaMetrics can't tell the two sets apart, so Observability has no way to drop one and keep the other. See the Slack thread.What is the new behavior?
Each push adds
extra_label=scope=globalorextra_label=scope=tenant, based on the metric set in that request. This works with today's single pusher and with the split pushers. No config changes are needed.Additional context
sum by (...)are unaffected. Panels that plot raw series may show a break at deploy.mix test test/realtime/metrics_pusher_test.exs. A new test covers the single-pusher case, and the:globaland:tenanttests now also check the label.🤖 Generated with Claude Code