Repository navigation
Conversation
The asset picker's uploader treated any drag as an upload, so dragging an asset inside the picker covered it with "Drop File to Upload".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
In the asset picker, dragging an asset (say, onto a folder) covers the whole picker with "Drop File to Upload", even though nothing is being uploaded.
What this PR Does
The uploader now ignores drags that aren't carrying files, by checking for
FilesindataTransfer.types. Dragging files in from your computer works as before.The main asset browser avoids this by switching its uploader off while you drag an asset, but the picker wraps the browser in its own uploader, which never got that signal. I went with the check in the uploader rather than passing the same signal through to the picker, as it fixes it for every place the uploader's used (including the Assets, Files and Markdown fieldtypes) without any extra wiring.
picker-upload-overlay.mp4
How to Reproduce