Skip to content

[REFACTOR/#1714] 콕찌르기 메인 뷰 compose 마이그레이션 - #1718

Open
Hyobeen-Park wants to merge 5 commits into
developfrom
refactor/#1714-migrate-poke-main
Open

Hyobeen-Park wants to merge 5 commits into
developfrom
refactor/#1714-migrate-poke-main

Conversation

@Hyobeen-Park

Copy link
Copy Markdown
Contributor

Related issue 🛠

Work Description ✏️

  • 콕찌르기 중 메인 뷰 컴포즈로 마이그레이션 및 mds 적용했습니다
  • 로띠 레이아웃이 내 친구 뷰에서 사용하는 것과 동일해서 패키지 이동 후 사용했습니다

Screenshot 📸

image

Uncompleted Tasks 😅

N/A

To Reviewers 📢

콕찌르기 마이그레이션 끄읏-!

@Hyobeen-Park Hyobeen-Park added this to the 39th Android milestone Oct 15, 2026
@Hyobeen-Park Hyobeen-Park self-assigned this Oct 15, 2026
@Hyobeen-Park
Hyobeen-Park requested a review from a team as a code owner October 15, 2026 18:44

@seungjunGong seungjunGong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마찬가지로 머지후 리뷰 요청주세요!

)

PokeProfileCard(
user = recommendation.users[0],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1: 두 번째 PokeProfileCard는 users[1] 이 되어야하는 거 맞을까요?
그리고 users가 비어 있으면 크래시가 날 수 있어서, 0/1/2명일 때를 나눠 처리하면 좋을 것 같습니다

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

허업!!!!!!!!!!! 1이어야 하는거 맞아요!!!! 큰일 날 뻔했네요..ㅎㅎ 근데 혹시 users가 0,1명만 오는 경우도 있나요???? 2명 아니면 아예 리스트 자체가 안 왔던 것 같아서요..!!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 1명만 오는 경우도 본 것 같아요! users.forEach로 그리는 방식으로 적용하면 좋을 것 같습니다!

}.onApiError { statusCode, message ->
Timber.e("statusCode: $statusCode, message: $message")
closeBottomSheet()
_sideEffect.emit(PokeMainSideEffect.ShowSuccess(message))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p1: 메시지 목록 조회 실패인데 ShowSuccess로 내려가고 있어서 ShowError로 바꿔야 할 것 같아요!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 수정했습니다!

)
}

val messageType = if (target.isFirstMeet) PokeMessageType.REPLY_NEW else PokeMessageType.POKE_FRIEND

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2: 기존에 POKE_SOMEONE 만 썼던걸로 알고 있는데 REPLY_NEW 를 추가하신 이유가 있을까요? jw 입니다

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 기존 코드는 따로 안 보고 아예 새로 구현하듯이 작업해서 명세서대로 보고 구현한건데 지금 REPLY_NEW를 사용하지 않고 있는걸까요?? 그런거면 코드 삭제하고 명세서도 수정해야 할 것 같아서요!!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 명세서 저에게도 공유 주실수 있으실까요? 잘 못찾겠네요ㅜ
아요도 POKE_SOMEONE 으로만 쓰고 있는거 같아서, 코드 혹은 명세 중 하나가 레거시인데 반영이 잘안된것 같네요 ㅎ..

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거는 음 일단 머지하고 확인후에 앱팀 쪽에서 적용해볼게요..!

getOnboardingPokeUserListUseCase(randomType = "ALL", size = 2)
.onSuccess { list ->
_uiState.update { it.copy(recommendations = list.toPokeRecommendationUiStates()) }
}.onApiError { statusCode, message ->

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p4: 추천 목록은 서버 에러(onApiError)일 때는 로그만 남기고, 네트워크 실패(onFailure)일 때만 스낵바를 띄우고 있는데 fetchFriend랑 기준이 달라서 의도한 건지 궁금합니다!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얾.. 구냥 깜빡한 것 같아요..하핫 수정했습니다`!

…rate-poke-main

# Conflicts:
#	feature/poke-v2/src/main/java/org/sopt/official/feature/poke/v2/component/PokeRelationChangeLottie.kt
#	feature/poke-v2/src/main/java/org/sopt/official/feature/poke/v2/component/PokeRelationChangeOverlay.kt
#	feature/poke-v2/src/main/java/org/sopt/official/feature/poke/v2/component/PokeSoulmateReveal.kt
#	feature/poke-v2/src/main/java/org/sopt/official/feature/poke/v2/model/PokeRelationChangeState.kt

@seungjunGong seungjunGong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셧습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REFACTOR] 콕찌르기 메인 뷰 마이그레이션

2 participants