Repository navigation
ios: offer Claude as a setup token, as web does - #2020
Merged
Merged
Conversation
Claude is setup token only and the cloud now returns claudeSignIn:false, so the chooser says "Use a Claude setup token" and its screen's one button says "Add setup token", not "…instead". The live providers UI test now expects that screen: no Claude page to open and no code field.
Matches Android (#2019) and Steve's rule rather than the server's claudeSignIn flag: no Open Claude, code field, start/watch/send, or Claude finish/cancel calls. The chooser offers Claude only with setup tokens; ChatGPT's sign-in is unchanged.
Contributor
Author
|
Merge note for hosted CI run 42562470287. uikit passed on both attempts.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude providers are setup-token only (Steve's rule; prod returns
claudeSignIn: false). Android removed the same branch in #2019.claudeSetupToken. The entry appears only when the server offers setup tokens.ClaudeSignInViewControlleris now the setup token alone: the hint and a prominent "Add setup token" button. Its browser branch is gone: Open Claude, the code field, start/watch/send, and the Claude finish/cancel calls. It no longer depends on the server'sclaudeSignInflag. ChatGPT's sign-in is unchanged.HostedProvidersTestsfixture is now a setup-token server. Its Claude test asserts no open button or code field and attaches a screenshot.HappyCloudUITests.testGProviders…expects the token-only screen.docs/SERVER-SIGN-IN.mdis updated.Verified:
HostedProvidersTests7/7 on the simulator, and 7/7 on the iPhone 12 at the first commit, which is where the screenshot comes from.HappyCore'sfinishCloudSignInAPI binding remains, unused by the UI.