Repository navigation
android: remove the classic Connect Claude screen - #2017
Merged
Merged
Conversation
The settings page that told people to run `happy connect claude` belongs to the classic Happy server and nothing in Settings opened it. Remove the screen, its route, the settings/connect/claude deep link (it now opens Home like any other unknown app path), its strings in every locale, its layout test and its baseline-profile entries. The Happy Cloud provider flow, including the Claude setup token, is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the classic Happy-server "Connect to Claude" settings screen (the
happy connect claudeinstructions) from Android.ConnectClaudeScreen.ktand its layout test.ConnectClaudeRouteand its page fromSettingsRoutes.kt. No Settings row opened it.settings/connect/claudedeep link. There is no backward compatibility: like any other app path with no Android screen, it now opens Home.DeepLinksTestasserts this.settings_connect_claude*strings from all 10 locales, plus the screen's 20 stale baseline-profile lines.The Happy Cloud provider screens (
ui/connection/CloudProviders.kt) are untouched, so the Claude setup-token path stays.Verification (androids node)
assembleDebugbuilt.testDebugUnitTest+:crypto:test: 3,681 tests, 55 skipped. Its one failure was my first new assertion, which expected the old link to give null when the parser actually returns Home. I fixed the assertion and re-ran theui.connect.*andui.settings.*tests: they pass. I did not re-run the full suite after that fix.