Skip to content

fix(ios): hide Cloud project settings and mark Policy vaults - #2012

Merged
ex3ndr merged 2 commits into
mainfrom
steve/ios-cloud-settings-cleanup
Nov 9, 2026
Merged

ex3ndr merged 2 commits into
mainfrom
steve/ios-cloud-settings-cleanup

Conversation

@ex3ndr

@ex3ndr ex3ndr commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Small native Cloud-only settings cleanup:

  • Hide “Hide projects” in Appearance and both Settings/Home searches for Cloud accounts. Paired and self-hosted accounts retain it. Stale toggle actions cannot change another account's preference.
  • Preserve the authoritative policyVault flag through local and remote search presentation so Policy vault keeps its lock icon in the sidebar and search.
  • No vault permission changes: Policy documents remain editable through their ordinary document APIs; fixed-file protections are unchanged.

Audit found no native attach/detach-compute controls, Experimental/Dev/Cloud Server settings pages, WorkOS copy, or File tiers feature to remove. No empty removal PR or unrelated wire-model deletion.

Verification

  • Before fixes: Cloud visibility/search assertions and Policy vault icon assertions failed; paired/self-hosted behavior passed.
  • Fresh verification on rebased head 7856b41ff, Kirill Mac simulator: 21 core tests passed, 15 hosted tests passed, 484 UIKit tests executed with zero failures and one existing Reduce Motion skip.
  • Final in-memory credential fixture: all 4 new hosted cleanup cases passed again.
  • Independent read-only review passed with no findings.

Fresh evidence: /Users/kirilldubovitskiy/ctb-out/cloud-cleanup.CABurk/. Earlier proof: cloud-cleanup.DoJiPN/ (including isolated-hosted.xcresult); red proof cloud-cleanup.LdDbFM/.

Rebased onto main 3f616d0b6431b7cdc1a8f37066381cddb2baeed7 after the prerequisite feature/lifecycle PRs merged. The full cleanup commit is unchanged by range-diff (=); no conflicts. Independent rebase-drift review and fresh native verification both passed.

No physical-device actions, release, or preview upload. Review/CI only; do not merge this queued PR without further direction.

@ex3ndr

ex3ndr commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Final gate for reviewed head 7856b41ff57d45949cdf144282c8708c121b0396:

  • The single authorized required-UIKit retry passed (job). The first attempt failed only the pre-existing Mermaid row-replanning race, now being fixed separately in ios: wait for final Mermaid height report in row test #2013.
  • Both PolicyVaultSearch tests and all 4 CloudSettingsCleanup hosted cases passed CI.
  • Hosted failures remain exactly the previously reviewed timing/sample-count set: attachment-grid fling budgets; slow-upload ring sampling (two intermediate samples, completion reached); Chief of Staff ask timeout/caret; InstantSignOut; NavigationTiming; SystemMonitor. No additional retries were run.
  • Exact-head local simulator verification passed: 21 core tests, 15 hosted integration tests, and 484 UIKit tests with one existing skip; /Users/kirilldubovitskiy/ctb-out/cloud-cleanup.CABurk/.
  • Independent source/rebase review passed; the cleanup patch is unchanged by its rebase.

Normal squash merge under the expressly approved known-timing/sample-count gate. Overall hosted CI is not claimed green. No admin override, bypass, or Preview upload.

@ex3ndr

ex3ndr commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

The old head's authorized UIKit retry passed, but normal merge was blocked by a one-line conflict with newly merged Compute #2011. This is resolved in merge commit d84809e36b50977dbe2b233e1cfccb3a84a0b672, pushed normally without rewriting history.

Home search now combines the Cloud-filtered computer settings with the permission-gated Compute entry. The other automatic settings merges preserve both features. Independent exact-commit integration review passed with no findings; relative to its main parent, the cleanup remains 9 files, 191 insertions / 14 deletions (one extra formatting line).

Fresh exact-head native verification on Kirill Mac's simulator:

  • 21 core tests: passed.
  • 22 hosted integration tests: passed (all cleanup and Compute cases, unified settings, and profile settings).
  • 484 UIKit tests: zero failures, one existing skip.
  • Evidence: /Users/kirilldubovitskiy/ctb-out/cloud-cleanup.wul8Ve/.

Fresh CI for this new head is run 42540298940. The earlier green check is not being reused for the changed head. No Preview upload.

@ex3ndr

ex3ndr commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Final integration head: d84809e36b50977dbe2b233e1cfccb3a84a0b672.

  • Fresh required UIKit CI passed (job). All 4 cleanup and all 7 Compute hosted cases passed.
  • The three newly observed hosted failures were compared exactly as authorized, three times each on this head and on freshly fetched main 247e722a71f6ed137ec388236e3f167376d47c56: 9/9 passed on both. Cases: HeaderBar's switcher frame, BrowserStates secureConnectionFailure, and ChatList's reader/keyboard offset. Neither reproduced locally; recorded as CI-only flakes, without changing tests or app code.
  • Head evidence: /Users/kirilldubovitskiy/ctb-out/cleanup-compare-head-d848.Jb07no/ (6) and /Users/kirilldubovitskiy/ctb-out/cleanup-compare-head-d848-chat-list.5mZXNZ/ (3). Main evidence: /Users/kirilldubovitskiy/ctb-out/cleanup-compare-base-247e.zmj9k5/ (9).
  • The repeated live-artifact liveUnavailable versus serverNotResponding failure is separately deferred as a Cloud follow-up, now seen twice. Other hosted failures were the previously documented timing/sample-count cases and ComposeBot timeout (previously compared on head/base).
  • Exact integration native verification and independent review are recorded above: 21 core, 22 hosted integration, 484 UIKit tests (1 existing skip), all passing.

Explicit approval received to merge normally under this evidence. Overall hosted CI is not claimed green. No admin override, bypass, extra retry, or Preview upload.

@ex3ndr
ex3ndr merged commit 7b37e8e into main Nov 9, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant