Repository navigation
FIX Preserve NumPy masked-array fill values - #563
Open
ananya-kaul wants to merge 1 commit into
Open
ananya-kaul wants to merge 1 commit into
ananya-kaul wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX Preserve NumPy masked-array fill values
Saving and loading a masked array currently discards its custom fill value. For example, an integer array with fill_value=-99 uses 999999 after loading, changing the result of filled().
Persist the fill value using the existing NumPy node and restore it when constructing the masked array. Older files without this field retain their default behavior. The new child is included in the type audit and restricted to NdArrayNode.
Validation: 12 round-trip cases fail before the fix and pass afterward, covering integer, floating-point and string data, masked/unmasked arrays, and file/bytes APIs. A compatibility test covers files without the new field, and an audit regression rejects an unexpected child type. Persistence, legacy persistence and audit suites: 1083 passed, 1 skipped, 1 xpassed. Ruff lint/format and focused pyrefly check pass. Tested on macOS with Python 3.13.5; the full project suite and other platforms were not run.