Repository navigation
FIX numpy with an array of lists - #562
Open
adrinjalali wants to merge 1 commit into
Open
adrinjalali wants to merge 1 commit into
adrinjalali wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the fix preserving object-array shapes and cell types during deserialization.
No open issues 🎉
What changed in this PR
Fixes #561 by preserving the shape and cell types of NumPy object arrays containing equal-length sequences during deserialization.
Changes:
- Allocates object arrays using their recorded shape and assigns cells individually to prevent extra dimensions.
- Adds round-trip tests for list, tuple, and ndarray cells across one-, two-, and three-dimensional arrays.
- Documents the fix in the v0.17 changelog.
| File | Description |
|---|---|
skops/io/tests/test_persist.py |
Adds regression tests checking array shape, dtype, cell types, and values. |
skops/io/_numpy.py |
Reconstructs object arrays cell by cell using the saved shape. |
docs/changes.rst |
Records the sequence-valued object-array loading fix. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #561 (cc @landfvit)