Repository navigation
Add row-policy support while upstream PR 335 is pending - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the row-policy changes from AfterShip#335 into this fork so clickhouse-platform can use them without waiting for the upstream merge.
Adds CREATE, ALTER, DROP and SHOW support for row policies, including formatting and AST traversal.
Keeps the existing function-expression table-settings support on master. The upstream PR remains open and unchanged.
Upstream PR:
AfterShip#335
Validation
Validated the combined tree of fork master
1df7d404and row-policy head97207866in an isolated local checkout. The merge has no conflicts and the combined tracked tree is identical to the row-policy head.make test, including compatibility mode, passed.go vet ./...passed.make lintpassed with Go 1.24 and golangci-lint 1.64.5.The ASTVisitor interface gains policy visit methods. Downstream clickhouse-platform compilation and the fork dependency update remain separate work.