Skip to content

rust: Clean up Cargo manifests and unused dependencies - #3979

Open
sirlucjan wants to merge 2 commits into
mainfrom
rust-1.100
Open

sirlucjan wants to merge 2 commits into
mainfrom
rust-1.100

Conversation

@sirlucjan

Copy link
Copy Markdown
Collaborator

Address new Cargo warnings introduced with Rust 1.100.

  • Remove redundant homepage entries and an unused build dependency.
  • Drop unused dependencies across the workspace.
  • Update Cargo.lock accordingly.

No functional changes intended.

Every cargo invocation in the workspace prints the same block of
manifest warnings, twice in a package build (once for the fetch, once
for the build), which buries the warnings worth reading. Two kinds of
entry cause most of them and do nothing:

- scx_raw_pmu lists scx_utils under [build-dependencies] and has no
  build script, so the dependency is never built for one.

- six crates set `homepage` to the same URL as `repository`, which
  newer cargo reports as redundant (`cargo::redundant_homepage`): the
  field says nothing the repository link does not. Four of them warn
  today; the other two carry the same line and are cleaned with them.

The `lib.include` key of scx_rustland_core, which cargo also reports,
is left as it is.

No functional change, and Cargo.lock is untouched.

Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
Newer cargo checks each manifest for dependencies the crate never
refers to (`cargo::unused_dependencies`) and reports 28 of them across
14 crates on every build. They are leftovers of one kind or another;
in scx_utils they are six crates that only its build script uses and
that are listed under [build-dependencies] as well.

Remove the ones cargo names, each checked against the sources first:
none of the crates is mentioned in the Rust code of the package that
listed it.

- scx_utils: bindgen, libbpf-cargo, ruzstd, tar, version-compare and
  walkdir leave [dependencies]; the build script keeps its own.
- scx_lavd, scx_mavd: ordered-float, rlimit.
- scx_mitosis, scx_nitosis: cgroupfs, clap_main, itertools, maplit.
- scx_p2dq: ordered-float, sorted-vec.
- scx_rustland: ordered-float. scx_pandemonium: flate2. scx_flow:
  tiny_http. scx_arena: simplelog. xtask: toml.
- scx_raw_pmu, scx_userspace_arena: scx_utils.
- scxtop: scx_stats leaves [build-dependencies]; the build script
  does not use it, and the crate still depends on it the normal way.

cgroupfs, maplit and rlimit had no other user and drop out of
Cargo.lock; nothing else in it changes.

Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>

@arighi arighi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@arighi
arighi added this pull request to the merge queue Nov 13, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants