Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoding a binary value into a reused
OptionorEithercan retain data from its previous value. For example, decodingSome({Count: 0, Values: {"new": 2}})over a value containingCount: 7and an"old"map key leaves the count and old key behind. Gob omits zero-valued struct fields and merges into existing maps.Decode each selected value into a fresh variable, then assign it after successful decoding. This covers Option and every branch of Either/Either3/Either4/Either5 without changing the encoded format.
Added 30 regression cases across the 15 container branches, using both direct binary decoding and the public gob encoder/decoder. All 30 fail before the fix and pass afterward. Full race tests, build, vet, staticcheck, golangci-lint (0 issues), and formatting checks pass on Go 1.26.7/macOS arm64. Older supported Go versions are left to CI.
This intentionally replaces the selected value instead of merging it with the previous payload. No dependencies changed.
Prepared and tested with OpenAI Codex; not human-reviewed before submission.