Repository navigation
Add RBS for cache_method 0.2 - #1107
Merged
github-actions[bot] merged 2 commits intoOct 19, 2026
Merged
Conversation
cache_method includes CacheMethod::ClassMethods into Module and CacheMethod::InstanceMethods into Object at require time, so class bodies call cache_method and cache_method_clear_on with no explicit extend. Model those includes so Steep sees the DSL wherever the gem makes it available, along with CacheMethod.config and its Config. InstanceMethods declares a BasicObject self type: the implicit Object self type would make Object an ancestor of itself once the module is included into Object. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wo4FerFK9aaxrGrmVE9ncZ
Config#storage= is defined as storage=(storage = nil). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wo4FerFK9aaxrGrmVE9ncZ
apiology
marked this pull request as ready for review
October 19, 2026 20:02
|
@apiology Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was written by Claude Code on behalf of @apiology.
Problem
Steep rejects
cache_methodcalls in class bodies:Every class using the gem's documented DSL fails to type-check.
Solution
Adds RBS for cache_method 0.2, including
CacheMethod::ClassMethodsintoModuleandCacheMethod::InstanceMethodsintoObjectjust as the gem does at require time, socache_method,cache_method_clear_on,cache_method_clearandcache_method_cached?resolve wherever Ruby makes them available.InstanceMethodsdeclares aBasicObjectself type; the implicitObjectself type would makeObjectits own ancestor.