Repository navigation
docs(reid): what ReID costs in frames per second - #621
Open
AlexBodner wants to merge 6 commits into
Open
AlexBodner wants to merge 6 commits into
AlexBodner wants to merge 6 commits into
Conversation
BoT-SORT with no ReID, with each dataset's fine-tuned osnet_x1_0 and with fastreid_mot17_sbs50, timed over every sequence of the four tuning splits on one Colab T4 with a 2-vCPU Xeon, at library defaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The methodology incorrectly states that ReID encodes every detection rather than only high-confidence detections.
1 open finding
What changed in this PR
Adds measured ReID throughput costs to the BoT-SORT ReID guide.
Changes:
- Documents benchmark methodology and hardware.
- Compares FPS across four datasets and two encoders.
- Summarizes observed throughput reductions.
| File | Description |
|---|---|
docs/guides/reid.md |
Adds the ReID speed benchmark section and results. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tstanczyk95
reviewed
Oct 15, 2026
tstanczyk95
reviewed
Oct 15, 2026
tstanczyk95
reviewed
Oct 15, 2026
tstanczyk95
reviewed
Oct 15, 2026
tstanczyk95
left a comment
Collaborator
There was a problem hiding this comment.
@AlexBodner It's a promising table, but it needs clarification. See my remarks above.
AlexBodner
force-pushed
the
docs/reid-speed
branch
from
October 17, 2026 14:54
8379b14 to
f4ed78a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds a Speed section to the ReID guide, comparing BoT-SORT without ReID, with each dataset's fine-tuned
osnet_x1_0, and with the publishedfastreid_mot17_sbs50. Stacked on #571.The benchmark notebook contains the benchmark code and saved outputs used for the results below. Rerunning it requires access to the benchmark inputs and fine-tuned encoders.
Adding the fine-tuned OSNet made tracking 2.2 to 2.9 times slower than BoT-SORT alone. Adding FastReID made it 3.1 to 5.1 times slower.
How it was measured
tracker.updateonly. Frame decoding and detection parsing were outside the timed call; encoder loading happened at construction and was not timed.