Repository navigation
Docker: run community and business side by side - #13365
Draft
ericholscher wants to merge 5 commits into
Draft
ericholscher wants to merge 5 commits into
ericholscher wants to merge 5 commits into
Conversation
The webpack dev server URL and the presigned upload URL hardcoded the default host ports. Read RTDDEV_PORT_WEBPACK and RTDDEV_PORT_STORAGE so community and business can run side by side (readthedocs/common#335). Bumps common to the companion branch and documents the setup.
Documentation build overview
10 files changed ·
|
ericholscher
added a commit
to readthedocs/common
that referenced
this pull request
Oct 5, 2026
The community NGINX routes *.devthedocs.com to business instead (readthedocs/readthedocs.org#13365).
Replace the front proxy with the shared side-by-side NGINX template from common: whichever environment owns port 80 forwards the other one's domains to it.
ericholscher
changed the title
common now serves webpack, addons, storage and Elasticsearch by hostname through NGINX instead of host ports. Point the webpack dev server URL, its live reload CSP entry and the presigned upload URL at those hostnames, and drop the per-port settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the community and business local environments run at the same time (readthedocs/common#335 has the design). Companion: readthedocs/readthedocs-corporate#2158.
This PR:
common'sservices.conf.templateandside-by-side.conf.templateintodockerfiles/nginx/, and defaults community to forward.devthedocs.comto port10081. If business isn't running, those domains get a 502 from this NGINX.RTD_EXT_THEME_DEV_SERVERis nowhttp://assets.{PRODUCTION_DOMAIN}instead ofassets.devthedocs.org:10001. Business inherits it, so each environment uses its own webpack.connect-srcentry for webpack's live reload websocket follows that URL, and is only added when the dev server is set. Before,ws://{PRODUCTION_DOMAIN}:10001/wswas added unconditionally, including in production.storage.{PRODUCTION_DOMAIN}, not127.0.0.1:9000.docs/dev/install.rst. Both stacks take about 11 GB, and with Docker's default limit the OOM killer took a webpack container, which left a dashboard unstyled.The
commonsubmodule points at the #335 branch commit. It needs a re-bump tomainonce that merges.🤖 Generated with Claude Code