Repository navigation
Docker: use RustFS client to create buckets - #338
Merged
Merged
Conversation
MinIO archived mc and its downloads now return 410. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ericholscher
approved these changes
Oct 23, 2026
humitos
reviewed
Oct 26, 2026
| /usr/local/bin/rc bucket create -p myrustfs/media; | ||
| /usr/local/bin/rc bucket anonymous set download myrustfs/media; | ||
| /usr/local/bin/rc bucket create -p myrustfs/build-tools; | ||
| /usr/local/bin/rc bucket anonymous set download myrustfs/build-tools; |
Member
There was a problem hiding this comment.
Suggested change
| /usr/local/bin/rc bucket anonymous set download myrustfs/build-tools; | |
| /usr/local/bin/rc bucket public set download myrustfs/build-tools; |
We want to this to be public so we can upload tools downloaded from production S3 without recompiling them locally with something like readthedocs/readthedocs.org#13161
Member
Author
There was a problem hiding this comment.
This permission allows uploading using a password, that script uses a password, so it's safe.
stsewd
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Oct 26, 2026
MinIO archived the `mc` client, and `dl.min.io` now returns `410 Gone`. The `curl` call had no `--fail`, so the image saved the error page as `/usr/bin/mc`. Bucket creation on init silently failed, and `/static/` returned 403 locally. This installs `rc`, RustFS's own client, from its GitHub releases instead. The download uses `--fail` and checks the release checksum, so a dead URL now fails the image build instead of producing a broken binary. It also selects the binary for the build architecture (amd64 or arm64), where `mc` was hardcoded to amd64. Needs readthedocs/common#338, which switches `createbuckets.sh` to `rc`. The `common` submodule needs to be bumped once that is merged. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MinIO archived the
mcclient, anddl.min.ionow returns410 Gone. Our Dockerfiles download it without--fail, so/usr/bin/mcends up being the error page. That means no buckets get created on init,collectstaticfails withNoSuchBucket, and everything under/static/returns 403 locally.This switches
createbuckets.shtorc, RustFS's own client, which has nearly the same commands. The Dockerfile changes that installrcare in:Things to double-check:
download(anonymous read-only) instead ofpublic. Withpublic, anyone could upload files anonymously. Nginx only needs to read.bucket create -pskips existing buckets, so re-running the script no longer prints errors.🤖 Generated with Claude Code