Repository navigation
Agents: add front-end conventions - #336
Merged
Merged
Conversation
Write down the CSS naming, theming and template conventions that come up in review on the theme repository. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfbXavRE9UKS28VnSZikcL
ericholscher
force-pushed
the
claude/agent-rules
branch
from
October 5, 2026 12:43
a237857 to
fdb8028
Compare
ericholscher
changed the title
The theme repository carries a copy of the file but was not in the sync list, so it had drifted. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfbXavRE9UKS28VnSZikcL
The theme repository runs prettier on Markdown, so keep the shared file in the form prettier produces and the sync stays a no-op there. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfbXavRE9UKS28VnSZikcL
humitos
approved these changes
Oct 5, 2026
|
|
||
| - Most templates/css/js are in a separate repository (https://github.com/readthedocs/ext-theme/). | ||
| - Fomantic UI is the design system. Use an existing variation before adding CSS, and never use inline styles or `!important`. | ||
| - Name custom CSS as a variation on the Fomantic element it extends, like `.ui.invertable.image` or `.ui.labeled.image`, and keep it in that element's `.overrides` file in the theme. |
Member
There was a problem hiding this comment.
I'm not sure about this, but I think it's correct. cc @agjohnson
Member
Author
There was a problem hiding this comment.
Going to merge, but happy to address any feedback if it comes in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSS naming, theming and template conventions that come up in review on the theme repository aren't written down anywhere an agent reads them, so each one gets re-learned a review at a time. The Front-end section is where the shared file already points at ext-theme, so that is where they go.
ext-theme carries a copy of this file from earlier syncs but was missing from the sync list, and its pre-commit runs prettier on Markdown, which is how the copy drifted. Keeping this file in prettier's form means the sync lands there as a no-op under its hooks.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XfbXavRE9UKS28VnSZikcL