Repository navigation
Guard against overflow on exclusive IP range bounds - #3250
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
bound_range_inclusive_ip converted an exclusive bound with a raw +1 and -1 on the u128 address. Excluding the first or last representable address overflowed: a panic under overflow checks, and a wrap to the full range otherwise. Return None for that case, as the numeric sibling already does, so the weight falls through to EmptyScorer. Generated with Claude Opus 5. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bound_range_inclusive_ipconverts an exclusive bound to an inclusive one with a plain+ 1and- 1on the u128 address, so excluding the first or last representable address overflows. Release builds leave overflow checks off, so the add wraps and the range inverts: a query for addresses strictly aboveffff:ffff:ffff:ffff:ffff:ffff:ffff:ffffbecame the full range and matched every document in my test index instead of none. Undercargo test, where[profile.test]setsoverflow-checks = true, the same query panics in the scorer.The numeric sibling just below already returns
Nonefor this case throughchecked_addandchecked_sub, so I did the same and let the weight fall through toEmptyScorer.