Repository navigation
Return FieldDoesNotExist for query JSON paths containing a nul byte - #3243
Open
G26karthik wants to merge 1 commit into
Open
G26karthik wants to merge 1 commit into
G26karthik wants to merge 1 commit into
Conversation
The indexer ignores JSON paths containing a nul byte, so no such path can match. The query parser built a term from them anyway, and the stray nul was read as the end of the path, which tripped an assert in convert_to_fast_value_and_append_to_json_term.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QueryParserpanics when a JSON path in a query contains a nul byte, for examplejson.a\0b:hello. A nul byte marks the end of the path in a JSON term, so the term is malformed andconvert_to_fast_value_and_append_to_json_termhits itsassert_eq.The indexer already skips paths with a nul byte, so no such path exists in an index. I return
QueryParserError::FieldDoesNotExistincompute_boundary_termandgenerate_literals_for_json_object.The new test covers a term, a number, a phrase, a range and an IN set. It fails on main with the panic and passes now.
cargo test --lib query::query_parser: 64 passed.