Repository navigation
fix: strip debug symbols from release binaries - #464
Conversation
|
Hi @fennoai[bot]. Thanks for your PR. I'm waiting for a qiniu member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
No reportable defects were found across the three changed files. Linker argument grouping was validated for all 16 Makefile targets, and isolated Linux, macOS, and Windows builds passed; native execution confirmed version injection and panic stack traces remain intact. Full application build verification was blocked by uncached dependencies.
Reviewed head commit: 9fb2fd8b096f3ddbbf470b15eddf61c50fff04b9
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: fennoai[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Requested by @Nliver
发布二进制此前保留了符号表和 DWARF 调试信息,导致下载及解压后的文件偏大。为 Makefile、发布前构建检查和正式发布统一加入 Go 链接参数
-s -w,保留版本号注入和静态链接参数,并更新变更日志。Closes #421
验证结果:
readelf确认不含符号表和 DWARF 调试段;version正确输出注入值,--help正常运行。make -Bn all检查全部 16 个平台目标均带有-s -w和版本号参数;发布检查与正式发布的链接参数一致。make test、go vet ./...、gofmt -s -l .和git diff --check通过。make lint在 staticcheck 阶段因未修改 Go 文件中的既有问题失败,包括弃用的io/ioutil、未使用代码及SA4006;本次未改动 Go 源码。本地实际构建验证覆盖 Linux amd64,其余平台检查了生成的构建命令;未执行正式发布。